Separate image and background color values#7451
Closed
ickshonpe wants to merge 1 commit intobevyengine:mainfrom
Closed
Separate image and background color values#7451ickshonpe wants to merge 1 commit intobevyengine:mainfrom
ickshonpe wants to merge 1 commit intobevyengine:mainfrom
Conversation
Contributor
Author
|
Another motivation for this is to support forced aspect ratio images with letterboxing when they can't be made to fit into the UI layout (something I implemented in bevy_ui_exact_image). You'd use |
This was referenced Jan 1, 2024
Contributor
|
I believe #11165 included the changes that this PR would've addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
BackgroundColorcomponent is also used to control image color.BackgroundColorcould be used to set the color of the padded area.Solution
Add a
colorfield toUiImageand use it instead ofBackgroundColorfor image colors.Draw separate background and image rects for each node, if the respective components are present.
Changelog
Migration Guide
To set the color tint of an image, instead of using the
BackgroundColorcomponent use thecolorfield ofUiImage.